Skip to content

feat(encode): support int64 and uint64 cdata#109

Merged
membphis merged 1 commit into
mainfrom
codex/107-int64-cdata-encode
May 31, 2026
Merged

feat(encode): support int64 and uint64 cdata#109
membphis merged 1 commit into
mainfrom
codex/107-int64-cdata-encode

Conversation

@membphis
Copy link
Copy Markdown
Collaborator

@membphis membphis commented May 31, 2026

Summary

  • expand qjson.encode coverage for LuaJIT int64_t/uint64_t cdata, including top-level, object, nested, boundary, decoded round-trip, and lua-cjson contrast cases
  • keep unsupported cdata rejection covered for double, struct, and pointer values
  • harden cdata integer suffix stripping with a single U/u/L/l suffix pass while preserving a single return value from qjson.encode

Closes #107

Testing

  • PATH="$HOME/.luarocks/bin:/usr/local/bin:$PATH" make test
  • make lint
  • cargo test --release --no-default-features
  • cargo test --no-default-features
  • cargo test --features test-panic --release
  • PATH="/tmp/qjson-luacheck/bin:$PATH" make lua-lint
  • cargo audit

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026 •
edited
Loading

Warning

Review limit reached

@membphis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 571e021c-85f4-43d2-ab79-73a296af15d0

📥 Commits

Reviewing files that changed from the base of the PR and between de0d800 and cf059c5.

📒 Files selected for processing (2)
  • lua/qjson/table.lua
  • tests/lua/encode_errors_spec.lua
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/107-int64-cdata-encode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@membphis membphis changed the title test(encode): cover int64 cdata encoding feat(encode): support int64 and uint64 cdata May 31, 2026
@membphis membphis force-pushed the codex/107-int64-cdata-encode branch from 95c6e87 to cf059c5 Compare May 31, 2026 04:21
@membphis membphis merged commit 8f46d27 into main May 31, 2026
8 checks passed
@membphis membphis deleted the codex/107-int64-cdata-encode branch May 31, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(encode): support LuaJIT int64_t/uint64_t cdata in qjson.encode

1 participant

@membphis